[DBInstance] Add region validation for the attributes AutomaticBackup… #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ReplicationRegion, SourceDBInstanceIdentifier and SourceDBClusterIdentifier
ccmlst
reviewed
Aug 7, 2024
| /** | ||
| * There are fields in the request (e.g. SourceDBInstanceIdentifier and SourceDBClusterIdentifier) that accept 2 types | ||
| * of identifiers: InstanceId or ARN. In the case of containing an ARN, we need to validate that the region is correct, | ||
| * as it will be used to contract the client endpoint, and a malformed region would lead to both security issues |
There was a problem hiding this comment.
typo: "contract" instead of "contact".
ccmlst
approved these changes
Aug 7, 2024
zrfr
reviewed
Aug 15, 2024
Comment on lines
+389
to
+391
| Validations.validateSourceRegion(request.getDesiredResourceState().getAutomaticBackupReplicationRegion()); | ||
| assertValidRegionFromArnOrIdentifier(request.getDesiredResourceState().getSourceDBInstanceIdentifier()); | ||
| assertValidRegionFromArnOrIdentifier(request.getDesiredResourceState().getSourceDBClusterIdentifier()); |
There was a problem hiding this comment.
The error message "Unknown source region" could be misleading for these properties. We should have a different error message for this specific case.
zrfr
requested changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS::RDS::DBInstance takes an AWS region name as input without validation and passes it directly into the AWS Java SDK v2 client. This can be specified in the AutomaticBackupReplicationRegion, SourceDBInstanceIdentifier, SourceDBClusterIdentifier properties.
The consequence of not validating this field is both a possible security issue where you could try to hit user-specified URLs, and also when it fails, it gives back a non-friendly error response to the client, making it hard to troubleshoot.